Don't store request specific data into the Layer object#5426
Closed
Congelli501 wants to merge 1 commit intoexpressjs:masterfrom
Closed
Don't store request specific data into the Layer object#5426Congelli501 wants to merge 1 commit intoexpressjs:masterfrom
Congelli501 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Contributor
|
Hello, and thank you for your pull request. Apologies, as I would have mentioned it before if there was an issue, but pull requests against the router files should be made over at https://github.com/pillarjs/router which is synced here (and removed outright in 5.x). If you do reopen, please be sure to include tests cases, as we need those to accept a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the path & params of the latest request is stored into the last matched layer.
The "Layer" object should be immutable: a request should not modify its attributes.
This means that parameters are kept into memory after the end a request.
For example, this code will show the latest value of the parameter, as the value is stored until a new request is made:
Result: