👷 add CI #63
Merged
👷 add CI #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctcpip
force-pushed
the
191
branch
16 times, most recently
from
2f4a522 to
168d901
Compare
ctcpip
force-pushed
the
191
branch
2 times, most recently
from
f61bc12 to
4c4cfdc
Compare
bjohansebas
reviewed
Jul 17, 2025
test/test.js
Outdated
| var server = createServer(null, null, function (req, res) { | ||
| assert.ok(req.timedout) | ||
| res.end('Hello') | ||
| if (!(res.finished || res.writableEnded)) { |
Member
There was a problem hiding this comment.
on-finished for this? Just a suggestion.
Member
There was a problem hiding this comment.
But that package has the isFinished method, which should work.
bjohansebas
approved these changes
Jul 17, 2025
bjohansebas
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #48