CPD does not run

[amenk]

See here

https://github.com/iMi-digital/magento2-friendly-captcha/actions/runs/25550965725/job/74998510410

 Runtime:       PHP 8.3.30
Configuration: /m2/dev/tests/static/phpunit.phpcpd.xml

Could not open input file: /m2/./vendor/bin/phpcpd
S                                                                   1 / 1 (100%)

Time: 00:00.028, Memory: 10.00 MB

OK, but some tests were skipped!
Tests: 1, Assertions: 0, Skipped: 1.

I am looking into it.

[convenient]

https://github.com/sebastianbergmann/phpcpd

This project is no longer maintained and its repository is only kept for archival purposes.

I think there are some short circuits in the magento code if this module is not installed so that it just skips and returns early.

PHP 8.3 sounds like a later version on which this may not be installed

[amenk]

It's not in the require-dev of https://github.com/magento/magento2/blob/2.4-develop/composer.json

I have some crazy workaround for the entrypoint.sh (via Codex) which uses https://github.com/systemsdk/phpcpd

The interesting part is, that CPD is green in our extension after this fix and Adobe Marketplace Team still complains. I will try to figure out, which ruleset they are using.

#!/bin/sh -l
set -eu

phpcpd_dir=/tmp/phpcpd-v8.3.0

if [ ! -f "$phpcpd_dir/phpcpd" ]; then
    rm -rf "$phpcpd_dir"
    mkdir -p "$phpcpd_dir"
    curl -fsSL https://api.github.com/repos/systemsdk/phpcpd/tarball/v8.3.0 \
        | tar -xz --strip-components=1 -C "$phpcpd_dir"
    composer --working-dir="$phpcpd_dir" install --no-interaction --no-dev --prefer-dist --no-progress
fi

mkdir -p /m2/vendor/bin

if [ ! -f /m2/vendor/bin/phpcpd-extdn-upstream ] && [ -e /m2/vendor/bin/phpcpd ]; then
    mv /m2/vendor/bin/phpcpd /m2/vendor/bin/phpcpd-extdn-upstream
fi

cat > /m2/vendor/bin/phpcpd <<'EOF'
#!/bin/sh
set -eu

phpcpd_dir=/tmp/phpcpd-v8.3.0

args=""
skip_next=0

for arg in "$@"; do
    if [ "$skip_next" -eq 1 ]; then
        skip_next=0
        continue
    fi

    if [ "$arg" = "--names-exclude" ]; then
        skip_next=1
        continue
    fi

    if [ -z "$args" ]; then
        args=$(printf "%s" "$(printf '%s' "$arg" | sed "s/'/'\\\\''/g")")
    else
        args="$args '$(printf '%s' "$arg" | sed "s/'/'\\\\''/g")'"
    fi
done

eval "exec php $phpcpd_dir/phpcpd \$args"
EOF
chmod +x /m2/vendor/bin/phpcpd

exec /entrypoint.sh "$@"