Conversation
Member
cboulay
commented
Apr 24, 2026
cboulay
commented
- delegation from unit to processor
- sane default behaviour in processor
…t to set self._hash = -1 on change to settings not in `NONRESET_SETTINGS_FIELDS`
…ings`. This will require a change to other units in the wild else they will do a double-reset.
6 tasks
…ld). - Added _apply_composite_settings() helper with the full reconciliation logic: rebind settings, early-exit when only NONRESET fields changed, rebuild via _initialize_processors(new_settings), delegate to old.update_settings(new.settings) for same-type children, close + swap for type-mismatched or disappeared keys, re-run _validate_processor_chain(). - Added update_settings to both CompositeProcessor and CompositeProducer as one-line delegators.
5 cases covering state preservation via delegation, new-key insertion, disappeared-key close, no-op update, and composite-level NONRESET_SETTINGS_FIELDS skipping rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.