Replace LineStack with MultiLineGraphic for performance#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating phosphor from custom wgpu shaders to fastplotlib, performance regressed for dense multichannel displays. The root cause is that LineStack creates separate LineGraphic objects per channel, and the update loop in _update_graphics() performs N separate GPU buffer assignments:
@pperanich's MultiLineGraphic in his fastplotlib fork packs all lines into a single GPU buffer, allowing bulk updates in one assignment. This plan adopts his fork as an immediate performance fix.
See ezmsg-org/ezmsg#229