Test fixtures for MPI #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implement three test fixtures for MPI-related tests:
MpiBaseTestFixture: which defines the usual variables but does not initialise a world.MpiTestFixture: inherits from 1, and initialises a world.RemoteMpiTestFixture: useful for testing remote messaging locally, it sets the resources in each host as desired, but for this reason can't initialise the worlds transparently.I have also added a separate file to hold the remote messaging tests. I am aware this is a great example of something that can be tested using
dist-testsbut I think there's still value in mocking for single-host tests (?).Next step will be to add more remote messaging tests, as with #108 they will use a different mechanism than local messages.