Push snapshot diffs before reset, and thread results after #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
changed the title
Shillaker
commented
Jul 12, 2021
| private: | ||
| void applyDiffsToSnapshot( | ||
| const std::string& snapshotKey, | ||
| const flatbuffers::Vector<flatbuffers::Offset<SnapshotDiffChunk>>* diffs); |
Collaborator
Author
There was a problem hiding this comment.
This was never implemented/ used
Shillaker
commented
Jul 12, 2021
| id, | ||
| threadPoolIdx, | ||
| executingTaskCount); | ||
| oldTaskCount - 1); |
Collaborator
Author
There was a problem hiding this comment.
This logging wasn't thread-safe by accessing executingTaskCount directly.
Shillaker
changed the title
csegarragonz
approved these changes
Jul 13, 2021
| m.set_snapshotkey(snapshotKey); | ||
| } | ||
|
|
||
| // Dispatch the message, we expect them all to be executed other hosts |
Collaborator
There was a problem hiding this comment.
small typo "executed on other hosts"
Collaborator
Author
There was a problem hiding this comment.
Good spot, will fix in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thread completes on a remote host, we need to do three things: reset the executor, send the snapshot diffs, send the thread's results. Previously sending snapshot diffs was bundled with sending thread results, and done after resetting the executor. However, this doesn't make sense as the resetting may wipe out any changes that should be captured in the diffs.
Therefore, we need to send the diffs, reset the executor, then send the thread results (note that the thread results must always be sent after resetting the executor to ensure it's ready to be reused). There is already a stand-alone snapshot diffs message, so this PR switches to using that and removes the snapshot diffs from the thread results message.
The downside here is that completing a thread on a remote host now requires sending two messages rather than one, but this is unavoidable.
Changes:
Executorcode to push snapshot diffs before callingreset