Prepare for "Fix type-safety of torch.nn.Module instances": fbcode/a*
#3088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66233582 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 488 488
Lines 49769 49769
=======================================
Hits 47653 47653
Misses 2116 2116 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ezyang
added a commit
to ezyang/Ax
that referenced
this pull request
Nov 20, 2024
…a* (facebook#3088) Summary: In D52890934 we are tightening the type signature on attributes on nn Module. To do this, we need to first apply Pyre fixme to all sites that were relying on the old Any. This diff shards out all changes to files that begin with a. Differential Revision: D66233582
ezyang
force-pushed
the
export-D66233582
branch
from
06e0c5c to
d6ca8f1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66233582 |
ezyang
force-pushed
the
export-D66233582
branch
from
d6ca8f1 to
7c8fd99
Compare
ezyang
added a commit
to ezyang/Ax
that referenced
this pull request
Nov 20, 2024
…a* (facebook#3088) Summary: In D52890934 we are tightening the type signature on attributes on nn Module. To do this, we need to first apply Pyre fixme to all sites that were relying on the old Any. This diff shards out all changes to files that begin with a. bypass-github-export-checks "codemod only skipping PR review" Reviewed By: r-barnes Differential Revision: D66233582
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66233582 |
…a* (facebook#3088) Summary: In D52890934 we are tightening the type signature on attributes on nn Module. To do this, we need to first apply Pyre fixme to all sites that were relying on the old Any. This diff shards out all changes to files that begin with a. bypass-github-export-checks "codemod only skipping PR review" Reviewed By: r-barnes Differential Revision: D66233582
ezyang
force-pushed
the
export-D66233582
branch
from
7c8fd99 to
86c05e2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66233582 |
Contributor
|
This pull request has been merged in 1efbcbd. |
bowiechen
added a commit
to bowiechen/Ax
that referenced
this pull request
Nov 21, 2025
Summary: Pull Request resolved: meta-pytorch/botorch#3088 Differential Revision: D87671961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In D52890934 we are tightening the type signature on attributes on nn Module. To do this, we need to
first apply Pyre fixme to all sites that were relying on the old Any. This diff shards out all changes
to files that begin with a.
Differential Revision: D66233582