Re-enable babel-plugin-transform-react-constant-elements when it’s not buggy

[gaearon]

See #525 for the reference.

[gaearon]

Here’s a list of bugs I found by searching. I think it’s on us to triage and fix them.

transform-react-constant-elements

• transform-react-constant-elements with multiple components in same file defunct (T6878) babel/babel#3915
• Error with babel-plugin-transform-react-constant-elements with components declared in the same file (T7126) babel/babel#4106
• babel-plugin-transform-react-constant-elements incorrectly hoisting react element (T7266) babel/babel#4223
• transform-react-constant-elements can swallow the props in some cases (T7403) babel/babel#4324
• Incorrect JavaScript generated with transform-react-constant-elements (T7520) babel/babel#4419
• babel-plugin-transform-react-constant-elements causing unreachable code (T7561) babel/babel#4458
• transform-react-constant-elements bug babel/babel#4516
• babel-plugin-transform-react-constant-elements - bug with incorrect declaration  babel/babel#4804
• [transform-react-constant-elements] Can't use this in react element name (T7494) babel/babel#4397
• transform-react-constant-elements => Element type is invalid babel/babel#5149
• transform-react-constant-elements => Acorn: SyntaxError: Unexpected token babel/babel#5325
• transform-react-constant-elements HOC params issue babel/babel#5315

transform-react-inline-elements

• Unable to use transform-react-inline-elements + transform-es2015-modules-commonjs with JSXMemberExpression (T6662) babel/babel#3728
• React inline elements transform error for namespaced JSX components using named import (T7021) babel/babel#4027
• transform-react-inline-elements doesn't work with transform-es2015-destructuring (T7557) babel/babel#4455

[DrewML]

Friendly update: I have a PR in to fix babel/babel#3728. Additionally, babel/babel#4455 doesn't appear to be an issue in the current version (based on my testing with the info provided in the issue). I'll be working on babel/babel#4027 pretty soon so that we can get transform-react-inline-element back into a usable state for y'all.

Once those are done, I'll start trying to look into the pile of react-constant-elements bugs 😑

[gaearon]

Wow, thank you!

[DrewML]

Alright, have a PR in for babel/babel#4027 now, too. Once those 2 PRs get merged, you should be ready to re-enable that plugin 😸

[DrewML]

These one's can be checked off for transform-react-constant-elements:

• transform-react-constant-elements with multiple components in same file defunct (T6878) babel/babel#3915
• Error with babel-plugin-transform-react-constant-elements with components declared in the same file (T7126) babel/babel#4106
• babel-plugin-transform-react-constant-elements incorrectly hoisting react element (T7266) babel/babel#4223

It turns out Sebastian fixed these here in July, and the issues just never got closed out.

Few more to go 😃

[DrewML]

OK, after the release today, all the bugs related to transform-react-inline-elements (that we know of) have been addressed. Please reach out if you see more once it is re-enabled.

[appden]

FYI: I just submitted PR babel/babel#4940 that fixes babel/babel#4419 and babel/babel#4804 (which should be added to the list above, and babel/babel#4458 should be updated as closed).

There's an existing PR (babel/babel#4787) to address babel/babel#4397, but it looks stalled on implementation details.

[Timer]

Neat, @appden! I've added babel/babel#4804 to the list.

I don't want to check off babel/babel#4458 (yet) because it seems to have been "magically" fixed without a trace of where the regression was introduced or resolved. We can save that one for last and determine if we want to let it slide.
I would love to see a test case added which prevents future regressions for that specific issue.
I'm not sure on other's opinions about this.