Skip to content

Reorganize webpack configuration structure #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheLarkInn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reorganize webpack configuration structure #7450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f91ab
Reorganize webpack configuration structure
TheLarkInn Jul 29, 2019
5ff14ae
Merge branch 'master' into feature/organize-config
TheLarkInn Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dev-utils/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,5 +412,5 @@ Returns a cache identifier (string) consisting of the specified environment and
```js
var getCacheIdentifier = require('react-dev-utils/getCacheIdentifier');

getCacheIdentifier('prod', ['react-dev-utils', 'chalk']); // # => 'prod:react-dev-utils@5.0.0:chalk@2.4.1'
getCacheIdentifier('production', ['react-dev-utils', 'chalk']); // # => 'prod:react-dev-utils@5.0.0:chalk@2.4.1'
Copy link
Author

@TheLarkInn TheLarkInn Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this because current usage of this function inside of webpack config(s) was "development" or "production".

Copy link
Contributor

@iansu iansu Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the comment too.

```
Loading