Skip to content

Use url-join to resolve URLs #754

@JoelMarcey

Description

@JoelMarcey

Is this a bug report?

No. Enhancement. But could fix unknown or future bugs.

See #745 for context.

https://github.com/facebook/Docusaurus/blob/master/lib/core/Head.js would be a good place to start with for a PR. instead of concatentating URL fragments with +, use the url-join npm package instead.

Have you read the Contributing Guidelines on issues?

Yes

Environment

N/A

Steps to Reproduce

N/A

Expected Behavior

N/A

Actual Behavior

N/A

Reproducible Demo

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    better engineeringNot a bug or feature requestdifficulty: starterIssues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.good first issueIf you are just getting started with Docusaurus, this issue should be a good place to begin.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions