Skip to content

fix(core): fix configurePostCss v3.2 regression#10012

Merged
slorber merged 1 commit intomainfrom
slorber/fix-configurePostCss-3.2
Apr 4, 2024
Merged

fix(core): fix configurePostCss v3.2 regression#10012
slorber merged 1 commit intomainfrom
slorber/fix-configurePostCss-3.2

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Apr 4, 2024

Motivation

My v3.2 refactors led to a regression, and configurePostCss was wrongly applied to the Webpack server config instead of client config.

Fix #10005

Test Plan

none 😅 I'll probably have to refactor things more to make this easier to test, for now I'm just fixing the regression asap.

Test links

https://deploy-preview-10012--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 4, 2024
@slorber slorber requested a review from Josh-Cena as a code owner April 4, 2024 10:37
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 4, 2024
@netlify
Copy link

netlify bot commented Apr 4, 2024

[V2]

Name Link
🔨 Latest commit b8a5791
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/660e82f5e6934a00088196b4
😎 Deploy Preview https://deploy-preview-10012--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Apr 4, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 98 🟢 100 🟢 100 🟠 88 Report
/docs/installation 🟠 59 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 71 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

@github-actions
Copy link

github-actions bot commented Apr 4, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 91.2 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 809 kB
website/build/index.html 38 kB

compressed-size-action

@slorber slorber merged commit f9a90d3 into main Apr 4, 2024
@slorber slorber deleted the slorber/fix-configurePostCss-3.2 branch April 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating to 3.2 breaks tailwind integration in production

2 participants