refactor: optimize bundling performance, pre-transpile client code so that sites don't have to#10062
Closed
refactor: optimize bundling performance, pre-transpile client code so that sites don't have to#10062
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -39.8 kB (-2%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
Collaborator
Author
|
I decided to stop investigating this optimization for now, because the impact is not significant enough compared to the extra complexity it involves. Here's the result on my computer (Mac M3) Bundling the initial template (contains few docs, mostly the theme code):
Bundling our website (more docs):
So:
For that reason, let's close this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The idea is that sites should not need to transpile official Docusaurus client code, saving time when bundling.
We can ship those client libs pre-transpiled by default so that they can be excluded from our JS loader.
There are some challenges to resolve:
<Translate>is preserved)Test Plan
tests + CI + dogfood
Test links
https://deploy-preview-10062--docusaurus-2.netlify.app/