Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
|
Hey @slorber I landed here because of the reference I found in code: docusaurus/packages/docusaurus-mdx-loader/src/processor.ts Lines 25 to 31 in b6644d8 I wonder if that type can be cleaned up now? Context: |
Collaborator
Author
|
@csantos-nydig you can do the cleanup in your own codebase But we can't do it on Docusaurus because it would emit d.ts files with newer TS features which require all users to upgrade TS (breaking change). We'll do the cleanup for the next major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade to latest TS stable version
Note: I'm not yet using mode-resolution (ttps://github.com/microsoft/TypeScript/issues/49721) (TS 5.3) because:
Test Plan
CI + min/max range tests (see #10063)
Test links
https://deploy-preview-10076--docusaurus-2.netlify.app/