Skip to content

chore: simplify TypeScript configs, use TS 5.5 configDir placeholder#10256

Merged
slorber merged 6 commits intomainfrom
slorber/ts-configDir
Jul 1, 2024
Merged

chore: simplify TypeScript configs, use TS 5.5 configDir placeholder#10256
slorber merged 6 commits intomainfrom
slorber/ts-configDir

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Jul 1, 2024

Motivation

Avoids useless inheritance config file duplication

Use the new ${configDir} placeholder in parent configs:

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#the-configdir-template-variable-for-configuration-files

Test Plan

CI

Test links

https://deploy-preview-10256--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 1, 2024
@slorber slorber requested a review from Josh-Cena as a code owner July 1, 2024 14:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 1, 2024
@netlify
Copy link

netlify bot commented Jul 1, 2024

[V2]

Name Link
🔨 Latest commit a559cb2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6682c54c3977d400080445ae
😎 Deploy Preview https://deploy-preview-10256--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 1, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 98 🟢 96 🟢 100 🔴 NaN Report
/docs/installation 🟠 76 🟢 97 🟢 100 🟢 100 🔴 NaN Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog 🟠 70 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 49 🟢 96 🟢 100 🟢 100 🔴 NaN Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 🔴 NaN Report

@github-actions
Copy link

github-actions bot commented Jul 1, 2024

Size Change: 0 B

Total Size: 1.85 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 27.3 kB
website/.docusaurus/globalData.json 123 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 304 kB
website/.docusaurus/routes.js 202 kB
website/.docusaurus/routesChunkNames.json 130 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 907 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber merged commit 6dd9a50 into main Jul 1, 2024
@slorber slorber deleted the slorber/ts-configDir branch July 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants