fix(translations): change casing of some en labels#10394
Merged
slorber merged 2 commits intofacebook:mainfrom Aug 13, 2024
Merged
fix(translations): change casing of some en labels#10394slorber merged 2 commits intofacebook:mainfrom
slorber merged 2 commits intofacebook:mainfrom
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
I think this has been done this way historically on purpose. Not sure we are willing to change that right now, considering all those labels can be overridden by users and nobody complained so far about the defaults. @Josh-Cena I'm sure you have an opinion on this 😄 |
Collaborator
|
I don't remember this ever being a conscious decision (and even if there was, it predated me since most of these are ancient features). That said, I'm +1 on this change to use sentence-case everywhere. |
Collaborator
|
Ok let's merge this then, and hope users wont complain about the change. In case you want to restore former behavior:
|
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 28, 2024
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
This was referenced Oct 20, 2024
Merged
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Some strings don't seem to match the overall semantics of Docusaurus. This PR aims to correct the given translation strings by converting them from pascal case to normal capitalization. Please correct me if this was done intentionally.