Update support for Web App Manifest#1046
Merged
JoelMarcey merged 4 commits intofacebook:masterfrom Oct 17, 2018
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 06ca233 |
JoelMarcey
approved these changes
Oct 17, 2018
yangshun
approved these changes
Oct 17, 2018
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
Thanks for coming around to fix this 😄
yangshun
pushed a commit
that referenced
this pull request
Oct 18, 2018
* add contributor list to each document * handle case where there is no github repo * Move to v1 * Revert "handle case where there is no github repo" This reverts commit a76a887. * Revert "add contributor list to each document" This reverts commit c0cc79f. * Add last updated by field * -Include enableUpdateBy in the config - Rename css class to be more general * Fix lint * Refactor : - s/getGitlastupdated/getGitLastUpdatedTime - refactor part in getGitLastUpdated[Time|By] that overlaps - remove getAuthorInformation * -Modify the display logic -Refactor the utils, combine lastupdatedtime and lastupdatedby -Replace the test * Modify docs based on the display change * Update docs for url and baseurl For more clarity and to make relationship more clear * Update support for Web App Manifest (#1046) * misc: update nits * misc: update nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies, I previously created a PR for adding Web App Manifest in the head.js but there was a mistake in implementation. The format of manifest should be as below:
<link rel="manifest" href="/manifest.json" />While the one I previously implemented was:
<link rel="manifest" content="/manifest.json" />attribute href should be used instead of content so that the browsers can detect properly the manifest in html
Thus this PR is a correction to the previous Implementation of Web App Manifest