Skip to content

refactor(core): use webpack's builtin prefetch & preload abilities to do prefetch & preload#10489

Closed
hardfist wants to merge 1 commit intofacebook:mainfrom
hardfist:yj/refactor-prefetch-preload
Closed

refactor(core): use webpack's builtin prefetch & preload abilities to do prefetch & preload#10489
hardfist wants to merge 1 commit intofacebook:mainfrom
hardfist:yj/refactor-prefetch-preload

Conversation

@hardfist
Copy link

@hardfist hardfist commented Sep 11, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

it seems ChunkAssetPlugin provides same functionalities like webpack's builtin prefetch & preload abilities, so try using webpack's builtin prefetch & preload runtimeModule and it's also compatible with rspack

Test Plan

It's a refactor so it can use the original prefetch & preload test

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

related to #10402 #10485

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 11, 2024
@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 72 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 52 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 64 🟢 96 🟢 96 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 65 🟢 96 🟢 96 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@hardfist hardfist marked this pull request as draft September 11, 2024 03:52
@hardfist hardfist closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants