feat: use doc's title or id as default when link name is not provided#1117
Closed
gianlucadonato wants to merge 3 commits intofacebook:masterfrom
gianlucadonato:feat_link_title
Closed
feat: use doc's title or id as default when link name is not provided#1117gianlucadonato wants to merge 3 commits intofacebook:masterfrom gianlucadonato:feat_link_title
gianlucadonato wants to merge 3 commits intofacebook:masterfrom
gianlucadonato:feat_link_title
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 5e9ddf4 |
Contributor
|
@gianlucadonato Hi! Thank you very much for the PR. However, doesn't this go against general markdown behavior. e.g., normally would create a hidden link. That may be what someone wants. That said, an argument could be made for what you want to do here for being able to update titles more easily. Anyway, I am happy to hear arguments for this the way you do it. Or maybe we can come up with a special syntax for what you want to do. I am going to close this, but please reopen to discuss more if you would like and we can consider the options to get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Feature
Use the doc's title or id as default when a link name in the markdown is not provided.
For example, when we have a link like
[](foo.md)it would be nice if Docusaurus could read the title of the document 'foo.md' and generate automatically a link to[Foo Title](foo.md).How it currently works
Example:
docs/doc1.md:
docs/doc2.md:
At the moment, in docs/doc2.md the link with empty name is omitted:
Output:
How it would work
In docs/doc2.md the link with empty name is replaced with the doc1's title (if exists) or it's id:
Output:
Have you read the Contributing Guidelines on issues?
Yes.