feat: use 'sidebar_label' instead of 'title' in prev/next buttons#1122
Merged
endiliey merged 2 commits intofacebook:masterfrom Nov 22, 2018
Merged
feat: use 'sidebar_label' instead of 'title' in prev/next buttons#1122endiliey merged 2 commits intofacebook:masterfrom
endiliey merged 2 commits intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit fcbf1b3 |
endiliey
approved these changes
Nov 22, 2018
Contributor
endiliey
left a comment
endiliey
left a comment
There was a problem hiding this comment.
We need to update the docs as well indicating that sidebar_label will also be used for next/prev button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
see #1085
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan