fix: docusaurus-version should allow duplicate id in different subfolder#1125
Merged
yangshun merged 4 commits intofacebook:masterfrom Nov 23, 2018
Merged
fix: docusaurus-version should allow duplicate id in different subfolder#1125yangshun merged 4 commits intofacebook:masterfrom
yangshun merged 4 commits intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 755ed04 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 2b2987d |
endiliey
changed the title
yangshun
approved these changes
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1113
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Created two files
ecosystem/bar.mdwith id: bar andhydra/bar.mdwith id: barFirst, cut version 1.0.0 and a versioned docs is created
After that, cut version 2.0.0 again
Note that I added some debugging console.log for easy purpose
Before
Note that the versioning command is confused with id
barsince it is not namespaced according to subdirectory.It incorrectly creates an extra version-2.0.0 file when there is no doc changes
After
Since there is no change, no new files created
