Skip to content

feat: customizable search placeholder#1126

Merged
yangshun merged 2 commits intofacebook:masterfrom
rea-app:search-placeholder
Nov 23, 2018
Merged

feat: customizable search placeholder#1126
yangshun merged 2 commits intofacebook:masterfrom
rea-app:search-placeholder

Conversation

@maxaggedon
Copy link
Contributor

Motivation

Some might want to change the search bar placeholder. Either for a non-english documentation or just for something funnier than Search.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

capture d ecran 2018-11-23 a 10 40 54

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 23, 2018

Deploy preview for docusaurus-preview ready!

Built with commit d2f2d9f

https://deploy-preview-1126--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants