Skip to content

fix(docs): Fix deployment docs for v3.9.1 - Node.js version should be v20#11474

Merged
slorber merged 2 commits intofacebook:mainfrom
egrosdou01:docs/fix-#11472
Oct 14, 2025
Merged

fix(docs): Fix deployment docs for v3.9.1 - Node.js version should be v20#11474
slorber merged 2 commits intofacebook:mainfrom
egrosdou01:docs/fix-#11472

Conversation

@egrosdou01
Copy link
Contributor

@egrosdou01 egrosdou01 commented Oct 12, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Updated my blog post to v3.9.1 and there was a need to update the GitHub actions to meet the NodeJS requirements. The for v3.9.1 documentation has the old NodeJS specification. Although, the canary version includes the correct information.

Fix #11472

Test Plan

This is a simple documentation change.

Test links

This is a simple documentation change.

Related issues/PRs

N/A

Signed-off-by: egrosdou01 <eleni.grosdouli@gmail.com>
@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Oct 12, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

We already had a fix for this but not backported to v3.9.1 docs: #11443

Can you please apply exactly the same fix as in the original PR? Looks like you missed a few cases

@slorber slorber changed the title Fix for issue #11472 fix(docs): Fix deployment docs for v3.9.1 - Node.js version should be v20 Oct 13, 2025
@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label Oct 13, 2025
@egrosdou01
Copy link
Contributor Author

Sorry, missed two Node versions. The PR should be good now.

@netlify
Copy link

netlify bot commented Oct 13, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 8a406f3
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/68ed40aa773b8100089cff12
😎 Deploy Preview https://deploy-preview-11474--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@slorber slorber merged commit 2a10b54 into facebook:main Oct 14, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docusaurus v3.9.1: Update GitHub Actions Example to Point to Node 20 Instead of 18

2 participants