docs: add a link to easily add your project with a form#1160
Closed
ymschaap wants to merge 1 commit intofacebook:masterfrom
Closed
docs: add a link to easily add your project with a form#1160ymschaap wants to merge 1 commit intofacebook:masterfrom
ymschaap wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 4140cad |
Contributor
|
@ymschaap Hi. This is actually really cool 😄 We definitely are interested in merging this, but we would need a few things first:
Thanks! |
yangshun
reviewed
Jan 23, 2019
Contributor
yangshun
left a comment
There was a problem hiding this comment.
@ymschaap This is a really cool feature! On top of what Joel mentioned, I have the following questions:
- Are we (Babel/Docusaurus maintainers), able to configure what we ask in the form or do we have to go through you if we want to make changes?
- Many contributors want the final PR/commit made under their own name. Currently the PR is made using your bot. Can that be changed to be made using someone's GitHub account? I think the user would need to login via GitHub.
Author
|
Great.
|
Contributor
|
What are the blockers of this PR ? |
Contributor
|
I think we are not going forward with this. Sorry. Thank you for the PR though 😉 |
This was referenced Feb 1, 2022
This was referenced Jul 4, 2023
This was referenced Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: this discussion: #1080 (comment)
Why:
Adding a project to the users list now involves forking, editing a js file, uploading a logo, creating a PR, reviewing. Which can be made much simpler with a Github bot that transforms a form submission into the right Pull Request.
What:
This PR links to a new web based submission form from the users page: https://build.amsterdam/your-company/docusaurus
How:
As gif:

Example Bot PR:
How a bot PR looks like:
ymschaap#3
Let me know your thoughts if interested work on merging.