fix: sidebar scrolling on ios devices#1161
Closed
teimurjan wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit aa26620 |
Contributor
Author
|
@yangshun Can someone check it, please? |
endiliey
reviewed
Mar 21, 2019
| } | ||
|
|
||
| function isIOS() { | ||
| var iOSDevices = ['iPad Simulator', 'iPhone Simulator', 'iPod Simulator', 'iPad', 'iPhone', 'iPod']; |
Contributor
There was a problem hiding this comment.
I can only comment from code perspective, but this part can definitely be refactored with something like
iosDevices.indexOf(navigator.platform)instead of the whole pop and while loop.
This also doesn't completely fix #877. #877 is related to glitchy scrolling on Mac Safari too. I don't have a Mac to test it out, unfortunately
Contributor
|
Thank you for the effort but we're not going forward with this. I don't think this is the right fix because the bug is also happening on mac Closing it due to stale activity as well |
This was referenced Feb 1, 2022
This was referenced Jul 4, 2023
This was referenced Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #877. The reason of the bug is specification of Safari on iOS devices. If for the Chrome is enough just to add overflow: hidden for the body, for Safari it does not work till you set the
position: fixed;. But in this way you lose your scrolling position. So I created a closure which saves the last scroll position in order to set it back when the sidebar is closed.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
First tab is the scolling before the fix. The second one is after.