feat(create-docusaurus): make base TS config strict by default#11699
Closed
slorber wants to merge 1 commit into
Closed
feat(create-docusaurus): make base TS config strict by default#11699slorber wants to merge 1 commit into
slorber wants to merge 1 commit into
Conversation
slorber
added
the
pr: breaking change
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +264 B (0%) Total Size: 11.8 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +254 B (0%) Total Size: 12.3 MB ℹ️ View Unchanged
|
Collaborator
Author
|
Not needed anymore because TS 6.0+ is strict by default: users will opt-in for strict by upgrading TS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For Docusaurus v4, we want to make the base TS config stricter by default
This is a TS breaking change, so we'll merge it only for v4
We can now remove the local strict: true setting applied to newly initialized sites, added in #11696
Test Plan
CI