fix: missing default value for grid block content objects#1186
Merged
yangshun merged 1 commit intofacebook:masterfrom Jan 16, 2019
Merged
fix: missing default value for grid block content objects#1186yangshun merged 1 commit intofacebook:masterfrom
yangshun merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
yangshun
approved these changes
Jan 16, 2019
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
Looks good. Thanks @marvinchin!
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 4495f0c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1184. The default value for the
alignImagekey was not applied.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
The screenshots below show the content of a GridBlock content component with the
alignImagekey omitted before/after the fix.Before (image missing):
After (image in left position):