Skip to content

fix: revert image-min back to dependencies#1201

Merged
JoelMarcey merged 1 commit intofacebook:masterfrom
ahmadalfy:revert-imagemin-to-dependencies
Jan 24, 2019
Merged

fix: revert image-min back to dependencies#1201
JoelMarcey merged 1 commit intofacebook:masterfrom
ahmadalfy:revert-imagemin-to-dependencies

Conversation

@ahmadalfy
Copy link
Contributor

Motivation

During the update of imagemin it was moved to dev-dependencies and broke the build. This will revert it back to dependencies

Have you read the Contributing Guidelines on pull requests?

Yes

Related PRs

#1162

Related issues:

#1200

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 24, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 68ba574

https://deploy-preview-1201--docusaurus-preview.netlify.com

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - sorry about this. Thanks for fixing it 👍

@JoelMarcey JoelMarcey merged commit 945f511 into facebook:master Jan 24, 2019
This was referenced Jan 24, 2019
@JoelMarcey
Copy link
Contributor

#1202

@JoelMarcey
Copy link
Contributor

1.7.1 published to npm - which should hopefully fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants