fix: docs asset links should follow specified docsUrl#1204
Merged
yangshun merged 1 commit intofacebook:masterfrom Jan 28, 2019
Merged
fix: docs asset links should follow specified docsUrl#1204yangshun merged 1 commit intofacebook:masterfrom
yangshun merged 1 commit intofacebook:masterfrom
Conversation
marvinchin
changed the title
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 4d7847c |
marvinchin
force-pushed
the
fix-docs-asset-link
branch
from
22322cc to
4d7847c
Compare
marvinchin
changed the title
yangshun
approved these changes
Jan 28, 2019
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
This is so awesome, thanks for investigating and fixing this @marvinchin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1177 and #1203. Generated asset links were not following the
docsUrlattribute specified insiteConfig.js. Docs assets were also placed into thedocsfolder in the build directory instead of following the specifieddocsUrl. This PR should fix these issues.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Development Environment
Set
docsUrlinsiteConfig.jstohelloand start local server. Asset links in docs should point to/hello/assets/ASSET_NAME. Docs assets should be served from/hello/assets/ASSET_NAME. Images should be displayed on the test site.Production Environment
Set
docsUrlinsiteConfig.jstohelloand build the site. Asset links in docs should point to/hello/assets/ASSET_NAME. Docs assets should be served from/hello/assets/ASSET_NAME. Images should be displayed on the test site. (See https://marvinchin.github.io/docusaurus-demo/hello/doc1)