Skip to content

feat(v2): implement client lifecycles dispatcher#1591

Merged
yangshun merged 2 commits intomasterfrom
yangshun/client-lifecycle-dispatcher
Jun 9, 2019
Merged

feat(v2): implement client lifecycles dispatcher#1591
yangshun merged 2 commits intomasterfrom
yangshun/client-lifecycle-dispatcher

Conversation

@yangshun
Copy link
Contributor

@yangshun yangshun commented Jun 8, 2019

Motivation

Allow client modules to respond to client lifecycle events.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested with testing files. Have since deleted them.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun requested a review from endiliey as a code owner June 8, 2019 06:48
return ['infima/dist/css/default/default.css', customCss];
return [
'infima/dist/css/default/default.css',
path.resolve(__dirname, './commonjs-module'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just for testing. Will remove later.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 8, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 8, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 7e00754

https://deploy-preview-1591--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 8, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 7e00754

https://deploy-preview-1591--docusaurus-preview.netlify.com

@yangshun yangshun changed the title WIP feat(v2): implement client lifecycles dispatcher feat(v2): implement client lifecycles dispatcher Jun 9, 2019
@yangshun yangshun merged commit 38a5e4d into master Jun 9, 2019
@yangshun yangshun deleted the yangshun/client-lifecycle-dispatcher branch June 9, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants