Skip to content

refactor(v2): stronger typing for blog plugin#2072

Merged
endiliey merged 2 commits intomasterfrom
endi/blog-typing
Nov 30, 2019
Merged

refactor(v2): stronger typing for blog plugin#2072
endiliey merged 2 commits intomasterfrom
endi/blog-typing

Conversation

@endiliey
Copy link
Contributor

Motivation

Fix typing, no logic change. So everything can autocomplete and blog plugin can meet our plugin types

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • Locally no compile error
  • Build ok
  • Dev ok

Just waiting CI

@endiliey endiliey added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 30, 2019
@endiliey endiliey requested a review from yangshun as a code owner November 30, 2019 15:18
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 30, 2019
@endiliey
Copy link
Contributor Author

I'm going to merge this out @lex111 , sorry but you'll have to merge the conflict in #2000 so that all TS error can be caught

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 30, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 18625c2

https://deploy-preview-2072--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 30, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 18625c2

https://deploy-preview-2072--docusaurus-preview.netlify.com

@lex111
Copy link
Contributor

lex111 commented Nov 30, 2019

Let's merge this PR and I will update #2000 from master branch, right?

@endiliey
Copy link
Contributor Author

Let's merge this PR and I will update #2000 from master branch, right?

yes

@endiliey endiliey merged commit 2297ae9 into master Nov 30, 2019
@endiliey endiliey deleted the endi/blog-typing branch November 30, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants