fix(v2): fix codeblock copy button not including blank lines#2285
Merged
yangshun merged 1 commit intofacebook:masterfrom Feb 16, 2020
kohheepeace:kohheepeace-fix-copy-code
Merged
fix(v2): fix codeblock copy button not including blank lines#2285yangshun merged 1 commit intofacebook:masterfrom kohheepeace:kohheepeace-fix-copy-code
yangshun merged 1 commit intofacebook:masterfrom
kohheepeace:kohheepeace-fix-copy-code
Conversation
kohheepeace
requested review from
lex111,
wgao19 and
yangshun
as code owners
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit b22135a |
yangshun
suggested changes
Feb 16, 2020
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
Thanks for the PR! Seems like this bug existed since really long ago when the Copy button was added. I tested the fix on https://deploy-preview-2285--docusaurus-2.netlify.com/docs/creating-pages and couldn't get it to work. Could you test and see as well?
You might need to modify packages/docusaurus-theme-live-codeblock/src/theme/CodeBlock/index.js instead/as well.
yangshun
reviewed
Feb 16, 2020
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
I made the changes for you. Thanks for the fix!
yangshun
approved these changes
Feb 16, 2020
yangshun
changed the title
Contributor
Author
|
Thanks for your help and approval! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2284 (copy button in CodeBlock ignores blank line in code block)
Have you read the Contributing Guidelines on pull requests?
Yes!
Test Plan
Related PRs
This is a PR to add "Copy" button #1643