docs(v2): clarify theme-original and theme-init#3111
Merged
slorber merged 2 commits intofacebook:masterfrom Aug 11, 2020
Jonathannsegal:3043
Merged
docs(v2): clarify theme-original and theme-init#3111slorber merged 2 commits intofacebook:masterfrom Jonathannsegal:3043
slorber merged 2 commits intofacebook:masterfrom
Jonathannsegal:3043
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 2df953b |
Collaborator
|
Hi and thanks. Unfortunately, after reading that doc I'm still not 100% convinced to understand those aliases and why they are useful in practice 🤪 Will need to understand first, and see how we could improve the doc later |
slorber
changed the title
Drewbi
reviewed
Aug 6, 2020
Co-authored-by: Drew Alexander <drewalexander986@gmail.com>
slorber
added
the
pr: documentation
Collaborator
|
Let's merge this for now, but keep the issue open, because I still feel the doc can be clearer |
Collaborator
|
Oh, that's unfortunate but this has been contributed to v1 docs while it's a v2 feature :( will fix that soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#3043
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Change to
api-pages.mdPage Require PathsRelated PRs
As explained by #2464 (comment)