Skip to content

fix(v2): apply default appId to Algolia search#3118

Closed
francoischalifour wants to merge 1 commit into
facebook:masterfrom
francoischalifour:fix/docsearch-default-appId
Closed

fix(v2): apply default appId to Algolia search#3118
francoischalifour wants to merge 1 commit into
facebook:masterfrom
francoischalifour:fix/docsearch-default-appId

Conversation

@francoischalifour
Copy link
Copy Markdown
Contributor

Motivation

This default appId hints the browser that the website will load data from this Algolia application, resulting in a faster search.

There was an issue when this appId fell back to the default one because the preconnect link targeted an undefined endpoint.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

See generated <link rel="preconnect"> in source code.

Related PRs

This default `appId` hints the browser that the website will load data from this Algolia application, resulting in a faster search.
@docusaurus-bot
Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 50f7a1f

https://deploy-preview-3118--docusaurus-2.netlify.app

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Jul 27, 2020

As seen on discord, superseeded by #3133

@slorber slorber closed this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants