fix: add serve to internalCommand#3451
Merged
lex111 merged 1 commit intofacebook:masterfrom Sep 23, 2020
Merged
Conversation
Right now `docusaurus serve my-dir` doesn't work because it's not registered as an internal command, thus always forced to invoked w/ `path.resolve('.')`. This fixes that
Contributor
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 8b74dac |
lex111
approved these changes
Sep 16, 2020
fanny
approved these changes
Sep 20, 2020
Contributor
Author
|
ping @yangshun |
Collaborator
|
Hi
Will be back from holidays on Monday 28.
Will catch up and merge prs asap when I'm back
Le lun. 21 sept. 2020 à 03:18, Long Ho <notifications@github.com> a écrit :
… ping @yangshun <https://github.com/yangshun>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3451 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PQOF47Z3HMVIJTIG7TSG2ZWFANCNFSM4RMMXGZA>
.
|
Contributor
|
I think it's ready for the merge now. |
slorber
pushed a commit
that referenced
this pull request
Sep 29, 2020
Right now `docusaurus serve my-dir` doesn't work because it's not registered as an internal command, thus always forced to invoked w/ `path.resolve('.')`. This fixes that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now
docusaurus serve my-dirdoesn't work because it's not registered as an internal command, thus always forced to invoked w/path.resolve('.'). This fixes thatHave you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Manually verified in formatjs
Related PRs