feat(v2): add optional custom wrapper class name for pages based on theme classic Layout#3457
Conversation
…heme classic Layout
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit bc0a7cd |
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
This is nice feature indeed, I think what else can we add a similar feature for MD page in its frontmatter?
---
title: my hello page title
description: my hello page description
wrapperClassName: hello
---
Content..
Alternatively, I can (in a later time) try to add Layout component related section to the Theme Classic page.
That would be great, we definitely need it.
|
@lex111 I have added the
|
|
@lex111 Is there anything more you would like to see implemented within this PR? 🙂 |
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
LGTM, we will write docs for Layout component in a separate PR.
|
@Simek thank you! |
@lex111 I'm happy to do this after I finish my part on the RN website migration. |
…heme classic Layout (#3457) * feat(v2): add optional custom wrapper class name for pages based on theme classic Layout * feat(v2): add optional custom wrapper class name for markdown pages * fix TS types
4 participants
Motivation
Some custom pages may require different layout or additional customizations to the main page wrapper.
This small PR introduces an ability to specify an optional, custom
wrapperClassNameto the theme classicLayoutcomponent.I have NOT updated the docs because I was not able to find the page which describes all other optional
Layoutprops. "Theme classic" and "Creating pages" only briefly mentionLayoutusage. The most properties is used in the "Migration guide" but still without a description.I can add the note about this feature if you will be able to tell me where to put it. Alternatively, I can (in a later time) try to add
Layoutcomponent related section to the Theme Classic page. 🙂Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Feature has been tested with the local Docusaurus V2 website.
Related PRs