docs(v2): adding and specifying powershell and cmd for deployment in windows section#3459
Merged
lex111 merged 6 commits intofacebook:masterfrom Sep 19, 2020
jeremyhager:master
Merged
docs(v2): adding and specifying powershell and cmd for deployment in windows section#3459lex111 merged 6 commits intofacebook:masterfrom jeremyhager:master
lex111 merged 6 commits intofacebook:masterfrom
jeremyhager:master
Conversation
- specified batch command is for cmd - added powershell as an option for deployment, changed to single quotes
- 2.0.0-alpha.63 - 2.0.0-alpha.64 - Next (Dev)
Contributor
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit bd1bfb2 |
lex111
reviewed
Sep 17, 2020
Contributor
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
How about using tabs for this docs change?
- bash, windows, powershell, and cmd are now part of <tabs> - default value is bash
- Next (dev) now has better syntax - 2.0.0-alpha-63 and 2.0.0-alpha-64 now include the tabs as well
Contributor
Author
|
I've updated the docs to include the change - bundled bash, powershell, and cmd together so they are all tabs: (bash is default). Let me know what you think |
lex111
suggested changes
Sep 18, 2020
Contributor
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
Let's stick to following order: Bash - Windows (instead of "cmd")- PowerShell
- Labels now are first-letter uppercase - eg. bash -> Bash - cmd is now Windows to align with original docs
- Removed spacing at end of `values` statement - Removed spacing between `<Tabs>` and `<TabItem>` - build successful locally
Contributor
Author
|
Done and done. Noticed you specified "Bash" vs "_b_ash" as well as "PowerShell", so I've updated the labels to reflect that: Had some issues with spaces and using |
lex111
approved these changes
Sep 19, 2020
Contributor
|
@jeremyhager thank you! |
Contributor
Author
|
Thank you!! |
slorber
pushed a commit
that referenced
this pull request
Sep 29, 2020
* Added powershell command for deployment - specified batch command is for cmd - added powershell as an option for deployment, changed to single quotes * - This affects the following versioned docs: - 2.0.0-alpha.63 - 2.0.0-alpha.64 - Next (Dev) * Changed deploy commands to tabbed - bash, windows, powershell, and cmd are now part of <tabs> - default value is bash * Changed deployment commands to tabs in v63 and 64 - Next (dev) now has better syntax - 2.0.0-alpha-63 and 2.0.0-alpha-64 now include the tabs as well * Updated lables in deploy and cmd to Windows - Labels now are first-letter uppercase - eg. bash -> Bash - cmd is now Windows to align with original docs * Removed `<Tab>` spacing in deploy section - Removed spacing at end of `values` statement - Removed spacing between `<Tabs>` and `<TabItem>` - build successful locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refs: #3389
The documentation for deploying in a Windows environment may not be as specific as it needs to be, example issue: #3389. Because of this I have added a powershell command for Windows and have specified that one is for command prompt (title cmd) and the other is for PowerShell (title powershell).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
yarn buildcd websiteyarn startCurrent (before changes):
Proposed (after changes):
Related PRs.
N/A
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)