feat(v2): add ability to set custom title delimiter in config#3460
feat(v2): add ability to set custom title delimiter in config#3460lex111 merged 7 commits intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit b853add |
@lex111 It is currently not possible on Windows due to many paths issues, I need to clone this branch and regenerate snapshots on macOS. 😉
|
|
@lex111 I have updated the validation tests results. 🙂 |
|
Hmm, I just thought, why does the delimiter param relates to the theme config, if it should rather be in the site config? Wouldn't it be better to move this parameter to the site config? |
|
@lex111 THB I'm focusing my efforts on the I have no interest in other themes (ie. |
|
I got you, I just meant that it is reasonable to place the title
delimiter in the site config scope, rather in the theme one. (Since
this change is sort of an *extension* to the title, which is in the
site config)
2020-09-24 18:29 GMT+03:00, Bartosz Kaszubowski <notifications@github.com>:
… @lex111 THB I'm focusing my efforts on the `theme-classic` package (as title
suggest), most of my recent PRs came to fruition because of migration issues
to V2 or missing features in comparison to V1. I also want to keep my
changesets as small as possible to speed up the review process and avoid
unnecessary issues.
I have no interest in other themes (ie. `theme-bootstrap`), the goal is to
migrate the React Native website (and I'm doing it in my free time), but if
you think that the lack of similar changes in other themes is a blocker I
will try to port/rewrite the changes for them.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3460 (comment)
|
Simek
changed the title
|
@Simek awesome thing, thank you a lot! |
* feat(v2): add custom title delimiter to the theme classic * fix validation tests * remove title delimiter fallback * move titleDelimiter to main config, update theme-bootstrap * remove test value from config * update test snapshot * Improve docs Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
4 participants
Motivation
Currently in the theme classics the generated title delimiter is hardcoded. This small PR adds a field to the
themeConfigwhich allows the user to specify their own delimiter character or even a string.This PR includes the small mention in the documentation and fixes few minor issues in the code blocks on theme classics page.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Feature has been tested with the local run of Docusaurus V2 website.
Preview
Related PRs
None