fix(v2): Fix markdownlint rules on template init/README#3465
fix(v2): Fix markdownlint rules on template init/README#3465slorber merged 1 commit intofacebook:masterfrom felipecrs:patch-1
Conversation
|
Hi @felipecrs! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 940f41d |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 79fb8d1 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit b8f863b |
fanny
left a comment
There was a problem hiding this comment.
Hey @felipecrs!
Thanks for your contribution! Could you provide more context about the rules? Because for me it's okay have the sections using h3 or ###.
|
Hi @fanny! Try here: https://dlaa.me/markdownlint/ (and paste in the original file) Or if you have VSCode, try the markdownlint extension. |
|
LGTM and seems to effectively fix rule 1. |
https://github.com/markdownlint/markdownlint