Skip to content

fix(v2): Fix markdownlint rules on template init/README#3465

Merged
slorber merged 1 commit intofacebook:masterfrom
felipecrs:patch-1
Sep 29, 2020
Merged

fix(v2): Fix markdownlint rules on template init/README#3465
slorber merged 1 commit intofacebook:masterfrom
felipecrs:patch-1

Conversation

@felipecrs
Copy link
Contributor

@felipecrs felipecrs requested a review from yangshun as a code owner September 19, 2020 04:03
@facebook-github-bot
Copy link
Contributor

Hi @felipecrs!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 940f41d

https://deploy-preview-3465--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 79fb8d1

https://deploy-preview-3465--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit b8f863b

https://deploy-preview-3465--docusaurus-2.netlify.app

Copy link
Contributor

@fanny fanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @felipecrs!

Thanks for your contribution! Could you provide more context about the rules? Because for me it's okay have the sections using h3 or ###.

@felipecrs
Copy link
Contributor Author

@slorber slorber changed the title Fix markdownlint rules on init/README fix(v2): Fix markdownlint rules on template init/README Sep 29, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 29, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 29, 2020

LGTM and seems to effectively fix rule 1.

@slorber slorber merged commit 1c251bc into facebook:master Sep 29, 2020
@lex111 lex111 added this to the v2.0.0-alpha.65 milestone Sep 29, 2020
@felipecrs felipecrs deleted the patch-1 branch February 3, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants