feat(v2): allow to use array of files in customCss field#3474
feat(v2): allow to use array of files in customCss field#3474slorber merged 2 commits intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built with commit 44ef7f5 |
|
@lex111 Yup, this PR should fix the mentioned issue by you too, but I have not added the Joi validator as Sebastien suggested in there. |
|
@Simek will you do that? Also we need to update the docs. |
|
@lex111 I'm not sure how to do this correctly, since Also it looks like an additional schema will be needed in |
|
I'm not very good at this either, alright, so let's wait until Sebastien comes back from vacation. |
|
For Joi validation add it in the classic theme option validation. |
ghost
mentioned this pull request
- fix bug (push instead of concat) - update docs - add theme config validation + tests
|
Hey, I've added the validation. Also fixed a bug because using concat instead of push was no-op :) |
* feat(v2): allow to use array of files in customCss field * customCss array: - fix bug (push instead of concat) - update docs - add theme config validation + tests Co-authored-by: slorber <lorber.sebastien@gmail.com>
6 participants
Motivation
This small PR fixes the issue with server build when array of files was specified in
customCssfield in the theme classic preset configuration.CC @slorber
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Successful server build of React Native website with multiple files in
customCss.Related PRs