feat(v2): Add @theme-init components to user theme#3485
Merged
slorber merged 2 commits intofacebook:masterfrom Sep 28, 2020
edno:refactor/init-theme-user
Merged
feat(v2): Add @theme-init components to user theme#3485slorber merged 2 commits intofacebook:masterfrom edno:refactor/init-theme-user
slorber merged 2 commits intofacebook:masterfrom
edno:refactor/init-theme-user
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 4a21e1f |
lex111
reviewed
Sep 25, 2020
Contributor
lex111
left a comment
There was a problem hiding this comment.
Let's create a separate function for this purpose to avoid code duplicating?
Contributor
Author
@lex111 - I've put the full iterator logic into a separate function. |
Collaborator
|
thanks, LGTM |
slorber
pushed a commit
that referenced
this pull request
Sep 29, 2020
* Add @theme-init components to user theme * Refactor loadThemeAlias duplicate code to function
Contributor
Author
|
Hi @slorber The documentation looks good to me. I even learn something new with |
Collaborator
|
thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Swizzled components currently do not have access to
@theme-initcomponents as it has been introduced in PR#2464 for Docusaurus components.Having access to initial theme components allows overriding default components without having to rewrite the entire component.
This PR extend the initial PR for providing access to
@theme-initcomponents for custom components.The point has been raised on the Discord channel #docusaurus-2-dogfooding.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested with a local instance and a custom code block:
Related PRs