Skip to content

chore(v2): add build size bot workflow Github CI workflow#3744

Merged
slorber merged 1 commit intofacebook:masterfrom
jcs98:jcs98/build-size-bot
Nov 16, 2020
Merged

chore(v2): add build size bot workflow Github CI workflow#3744
slorber merged 1 commit intofacebook:masterfrom
jcs98:jcs98/build-size-bot

Conversation

@jcs98
Copy link
Contributor

@jcs98 jcs98 commented Nov 13, 2020

Motivation

Feature for #3521

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

A comment is added to the PR with changes in the size of key built files
image

@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 3d32594

https://deploy-preview-3744--docusaurus-2.netlify.app

@jcs98
Copy link
Contributor Author

jcs98 commented Nov 13, 2020

@slorber
This uses a repo token in the workflow to make a comment:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
Can you please set it up?

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 16, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 16, 2020

Thanks @jcs98 , I'll see if I can get the token configured, as I don't have permission to add this secret myself

@slorber
Copy link
Collaborator

slorber commented Nov 16, 2020

Not sure but maybe it will work automatically after I merge?
https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow

let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants