Skip to content

chore(v2): upgrade ESLint deps#3767

Merged
slorber merged 3 commits intomasterfrom
lex111/upd-eslint
Nov 18, 2020
Merged

chore(v2): upgrade ESLint deps#3767
slorber merged 3 commits intomasterfrom
lex111/upd-eslint

Conversation

@lex111
Copy link
Contributor

@lex111 lex111 commented Nov 17, 2020

Motivation

Trying to update packages related ESLint. There are some changes to the rules to make the checks run successfully, but overall nothing special.

Several npm warnings have been fixed along with this update:

warning " > eslint-config-airbnb@18.1.0" has incorrect peer dependency "eslint@^5.16.0 || ^6.8.0".
warning " > eslint-config-airbnb@18.1.0" has incorrect peer dependency "eslint-plugin-react-hooks@^2.5.0 || ^1.7.0".
warning "eslint-config-airbnb > eslint-config-airbnb-base@14.1.0" has incorrect peer dependency "eslint@^5.16.0 || ^6.8.0".
warning " > eslint-plugin-jsx-a11y@6.2.3" has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6".
warning "eslint-plugin-jsx-a11y > axobject-query@2.1.1" has incorrect peer dependency "eslint@^5 || ^6".

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Deploy logs.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner November 17, 2020 09:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 17, 2020
'no-empty': WARNING,
'no-prototype-builtins': WARNING,
'no-case-declarations': WARNING,
'no-undef': OFF,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled this 'no-undef' rule as this causes a bunch of errors and to prevent double parsing in TS according to the recommendation from the issue typescript-eslint/typescript-eslint#2508

@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for docusaurus-2 ready!

Built with commit e2bf1a9

https://deploy-preview-3767--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 17, 2020

Size Change: -18 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +5 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.85 kB +6 B (0%)
website/build/main.********.js 108 kB 0 B
website/build/styles.********.css 17.3 kB -29 B (0%)

compressed-size-action

@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
allPluginDatas: Record<string, GlobalPluginData>,
pathname: string,
options?: GetActivePluginOptions,
): ActivePlugin | undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why this is removed?

https://mariusschulz.com/blog/function-overloads-in-typescript#version-4-function-overloads

this is TS function overload to have more precise typing when some options are used (ie different return type). Does it cause any problem with ESLint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad, fixed it.

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants