Merged
Conversation
|
[V1] Deploy preview success Built with commit 7bf5193 |
|
Size Change: -2 B (0%) Total Size: 28.8 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built with commit 7bf5193 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4109--docusaurus-2.netlify.app/classic/ |
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
You shouldn't use
<Layout permalink=""/>for your homepage (like we currently had for Docusaurus 2 website), the canonical URL should rather be inferred from site URL + current page path.This works better particularly for canonical URLs on translated pages (the french homepage canonical URL is
/frnot/Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
this should fix an SEO / i18n issue reported by https://technicalseo.com/tools/hreflang/ due to having bad canonical URLs on localized site homepage