chore(v2): Update workbox to v6#4120
Merged
slorber merged 1 commit intofacebook:masterfrom Jan 29, 2021
RDIL:workbox-6
Merged
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit c0873f1 https://app.netlify.com/sites/docusaurus-1/deploys/6012f039fdbaef000782af31 |
|
Size Change: 0 B Total Size: 28.8 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit c0873f1 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4120--docusaurus-2.netlify.app/classic/ |
RDIL
commented
Jan 28, 2021
| const registrations = await navigator.serviceWorker.getRegistrations(); | ||
| if (debug && registrations.length > 0) { | ||
| console.log( | ||
| `[Docusaurus-PWA][registerSW]: unregister service workers`, |
Contributor
Author
There was a problem hiding this comment.
just makes casing consistent with the file name
slorber
added
the
pr: maintenance
slorber
changed the title
Collaborator
|
Thanks, seems to keep working 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Its an update, updates are usually cool
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Looks to work just fine
Related PRs
n/a