Skip to content

fix(v2): fix navigation from homepage #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lex111 merged 1 commit into from
Jan 31, 2021
Merged

fix(v2): fix navigation from homepage #4136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions packages/docusaurus/src/client/baseUrlIssueBanner/BaseUrlIssueBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

import React, {useLayoutEffect} from 'react';
import React from 'react';
import {useLocation} from 'react-router-dom';

import Head from '../exports/Head';
Expand Down Expand Up @@ -63,19 +63,6 @@ document.addEventListener('DOMContentLoaded', renderBanner);
`;
}

// Normally if the baseUrl is correct, the banner will already be hidden by the critical CSS
// But we can still remove it totally from the DOM if it's not useful anymore
// This is kind of a "double security"
// It can also prevent the banner to appear if the CSS fails to load due to some network error
function useBannerRemover() {
useLayoutEffect(() => {
const banner = document.getElementById(BannerContainerId);
if (banner) {
banner.remove();
}
}, []);
}

function BaseUrlIssueBannerEnabled() {
const {
siteConfig: {baseUrl},
Expand All @@ -100,7 +87,6 @@ export default function BaseUrlIssueBanner(): JSX.Element | null {
siteConfig: {baseUrl, baseUrlIssueBanner},
} = useDocusaurusContext();
const {pathname} = useLocation();
useBannerRemover();

// returns true for the homepage during SRR
const isHomePage = pathname === baseUrl;
Expand Down