chore(v2): fix build size bot monitoring of js/css assets#4156
Merged
chore(v2): fix build size bot monitoring of js/css assets#4156
Conversation
|
[V1] Deploy preview success Built with commit b25e57f |
|
Deploy preview for docusaurus-2 ready! Built with commit b25e57f |
|
Size Change: +2 B (0%) Total Size: 28.8 kB ℹ️ View Unchanged
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4156--docusaurus-2.netlify.app/classic/ |
Collaborator
Author
|
I think merging is needed to test it (due to using |
slorber
added
pr: maintenance
slorber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Build size bot got broken by #3998
Note: we should likely figure out a way to output better chunk names as we have large bundles named "1" and "3" and even worst namings.
Probably worth investing in this after the Webpack 5 migration