docs(v2): Fix link to slash introduction svg#4229
docs(v2): Fix link to slash introduction svg#4229slorber merged 1 commit intofacebook:masterfrom SamChou19815:unbreak-slash-introduction-image-link
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 02049f0 https://app.netlify.com/sites/docusaurus-1/deploys/602be7b13b4d4d0007515f94 |
|
Size Change: +15 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 02049f0 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4229--docusaurus-2.netlify.app/classic/ |
|
Thanks @SamChou19815 ! I was really surprised by this problem as it worked before and I didn't change the actual code, just the doc. Found out the issue: I enabled the English language on Crowdin by mistake, so we upload sources and redownload them as English translations. Crowdin is yet very good to handle JSX (really hope they'll add mdx support!) and somehow convert some JSX attributes as plain strings: So I'll still merge this PR, and also disabled the English language on Crowdin |

Motivation
According to #4126, we shouldn't be using
baseUrlfor the images in markdowns. It also broke the image on the old versioned docs (You can also see this on https://v2.docusaurus.io/docs/):I replaced the
imgtag with markdown image link, to make it consistent with the latest docs.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Now fixed:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)