Skip to content

feat: Markdown page-specific head metadatas#5330

Merged
slorber merged 5 commits intomasterfrom
slorber/page-specific-metas
Aug 11, 2021
Merged

feat: Markdown page-specific head metadatas#5330
slorber merged 5 commits intomasterfrom
slorber/page-specific-metas

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Aug 10, 2021

Motivation

To give maximum control to the user, we should enable the user to declare page head metadatas on a per-md-file basis.

Fixes #2603

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

dogfooding on our site

Preview: https://deploy-preview-5330--docusaurus-2.netlify.app/docs/next/markdown-features/head-metadatas/

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Aug 10, 2021
@slorber slorber requested a review from lex111 as a code owner August 10, 2021 16:32
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 10, 2021
@github-actions
Copy link

github-actions bot commented Aug 10, 2021

Size Change: +691 B (0%)

Total Size: 793 kB

Filename Size Change
website/.docusaurus/globalData.json 36.2 kB +193 B (+1%)
website/build/assets/css/styles.********.css 93.1 kB -108 B (0%)
website/build/assets/js/main.********.js 403 kB +485 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 64.2 kB +277 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/blog/index.html 33.1 kB -26 B (0%)
website/build/docs/index.html 41.9 kB -26 B (0%)
website/build/docs/installation/index.html 49.6 kB -26 B (0%)
website/build/index.html 28.7 kB -26 B (0%)
website/build/tests/docs/index.html 22.5 kB -26 B (0%)
website/build/tests/docs/standalone/index.html 20.5 kB -26 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Aug 10, 2021

✔️ [V2]

🔨 Explore the source changes: 11e2807

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611397ad325b3f0007982f8b

😎 Browse the preview: https://deploy-preview-5330--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 10, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 91

Lighthouse ran on https://deploy-preview-5330--docusaurus-2.netlify.app/

@slorber slorber merged commit a2ab4d3 into master Aug 11, 2021
@slorber slorber deleted the slorber/page-specific-metas branch August 11, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement (v2): Allow authors to define a canonical URL to help with SEO

3 participants