feat: TypeScript presets/plugins should expose Options typing#5456
Merged
feat: TypeScript presets/plugins should expose Options typing#5456
Conversation
…emeConfig types + remove TS typechecking for the bootstrap theme
…emeConfig types + remove TS typechecking for the bootstrap theme
Collaborator
|
Can we also move |
Collaborator
Author
|
Yes just moved it. All these TS files are not very organized currently, we'll need to do further cleanup 🤪 |
|
✔️ [V2] 🔨 Explore the source changes: 468b541 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612f4408d8eca6000710d975 😎 Browse the preview: https://deploy-preview-5456--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5456--docusaurus-2.netlify.app/ |
|
Size Change: -2 B (0%) Total Size: 822 kB ℹ️ View Unchanged
|
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OptionstypeThemeConfigHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
IDE autocompletion works